> @@ -221,8 +221,10 @@ int mpc837x_usb_cfg(void)
>       int ret = 0;
>
>       np = of_find_compatible_node(NULL, NULL, "fsl-usb2-dr");
> -     if (!np || !of_device_is_available(np))
> +     if (!np || !of_device_is_available(np)) {
> +             of_node_put(np);
>               return -ENODEV;
> +     }
>       prop = of_get_property(np, "phy_type", NULL);
>
>       if (!prop || (strcmp(prop, "ulpi") && strcmp(prop, "serial"))) {

How do you think about to adjust the exception handling in this function
implementation a bit more according to the Linux coding style?

Regards,
Markus

Reply via email to