Hello Nicholas,
On Tue, Apr 09, 2019 at 02:40:05PM +1000, Nicholas Piggin wrote: > Using a jiffies timer creates a dependency on the tick_do_timer_cpu > incrementing jiffies. If that CPU has locked up and jiffies is not > incrementing, the watchdog heartbeat timer for all CPUs stops and > creates false positives and confusing warnings on local CPUs, and > also causes the SMP detector to stop, so the root cause is never > detected. > > Fix this by using hrtimer based timers for the watchdog heartbeat, > like the generic kernel hardlockup detector. > > Cc: Gautham R. Shenoy <e...@linux.vnet.ibm.com> > Reported-by: Ravikumar Bangoria <ravi.bango...@in.ibm.com> > Signed-off-by: Nicholas Piggin <npig...@gmail.com> Looks good to me. Reviewed-by: Gautham R. Shenoy <e...@linux.vnet.ibm.com> -- Thanks and Regards gautham.
