On Tue, Apr 09, 2019 at 01:34:21PM +0200, Peter Zijlstra wrote: > On Wed, Feb 27, 2019 at 08:05:14AM -0800, Ricardo Neri wrote: > > diff --git a/kernel/watchdog.c b/kernel/watchdog.c > > index 8fbfda94a67b..367aa81294ef 100644 > > --- a/kernel/watchdog.c > > +++ b/kernel/watchdog.c > > @@ -44,7 +44,7 @@ int __read_mostly soft_watchdog_user_enabled = 1; > > int __read_mostly watchdog_thresh = 10; > > int __read_mostly nmi_watchdog_available; > > > > -struct cpumask watchdog_allowed_mask __read_mostly; > > +static struct cpumask watchdog_allowed_mask __read_mostly; > > > > struct cpumask watchdog_cpumask __read_mostly; > > unsigned long *watchdog_cpumask_bits = cpumask_bits(&watchdog_cpumask); > > Hurmph, more struct cpumask, ideally this would get converted to > cpumask_var_t, I don't think we need this before the allocators work, do > we?
I see mm_init() is called before lockup_detector_init(); both from start_kernel(). Thus, IMHO, kzalloc should work at this point. Thanks and BR, Ricardo
