On Wed, Feb 27, 2019 at 12:40:36PM +0800, Wen Yang wrote:
> The call to of_get_next_child returns a node pointer with refcount
> incremented thus it must be explicitly decremented after the last
> usage.
> irq_domain_add_linear also calls of_node_get to increase refcount,
> so irq_domain will not be affected when it is released.
>
> Detected by coccinelle with the following warnings:
> ./drivers/pci/controller/dwc/pci-dra7xx.c:252:2-8: ERROR: missing
> of_node_put; acquired a node pointer with refcount incremented on line 241,
> but without a corresponding object release within this function.
> ./drivers/pci/controller/dwc/pci-dra7xx.c:255:1-7: ERROR: missing
> of_node_put; acquired a node pointer with refcount incremented on line 241,
> but without a corresponding object release within this function.
>
> Signed-off-by: Wen Yang <wen.yan...@zte.com.cn>
> Cc: Kishon Vijay Abraham I <kis...@ti.com>
> Cc: Lorenzo Pieralisi <lorenzo.pieral...@arm.com>
> Cc: Bjorn Helgaas <bhelg...@google.com>
> Cc: linux-o...@vger.kernel.org
> Cc: linux-...@vger.kernel.org
> Cc: linux-ker...@vger.kernel.org
> ---
> drivers/pci/controller/dwc/pci-dra7xx.c | 1 +
> 1 file changed, 1 insertion(+)
Applied the series to pci/misc for v5.2, thanks.
Lorenzo
> diff --git a/drivers/pci/controller/dwc/pci-dra7xx.c
> b/drivers/pci/controller/dwc/pci-dra7xx.c
> index ae84a69..627c91d 100644
> --- a/drivers/pci/controller/dwc/pci-dra7xx.c
> +++ b/drivers/pci/controller/dwc/pci-dra7xx.c
> @@ -247,6 +247,7 @@ static int dra7xx_pcie_init_irq_domain(struct pcie_port
> *pp)
>
> dra7xx->irq_domain = irq_domain_add_linear(pcie_intc_node, PCI_NUM_INTX,
> &intx_domain_ops, pp);
> + of_node_put(pcie_intc_node);
> if (!dra7xx->irq_domain) {
> dev_err(dev, "Failed to get a INTx IRQ domain\n");
> return -ENODEV;
> --
> 2.9.5
>
