Hi Michael,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on powerpc/next]
[also build test ERROR on v5.1-rc2 next-20190326]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improve the system]

url:    
https://github.com/0day-ci/linux/commits/Michael-Neuling/powerpc-Add-force-enable-of-DAWR-on-P9-option/20190326-135550
base:   https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next
config: powerpc-allnoconfig (attached as .config)
compiler: powerpc-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
        wget 
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O 
~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.2.0 make.cross ARCH=powerpc 

All errors (new ones prefixed by >>):

   arch/powerpc/kernel/process.c: In function '__set_breakpoint':
>> arch/powerpc/kernel/process.c:820:6: error: implicit declaration of function 
>> 'dawr_enabled'; did you mean 'radix_enabled'? 
>> [-Werror=implicit-function-declaration]
     if (dawr_enabled())
         ^~~~~~~~~~~~
         radix_enabled
   cc1: all warnings being treated as errors

vim +820 arch/powerpc/kernel/process.c

   815  
   816  void __set_breakpoint(struct arch_hw_breakpoint *brk)
   817  {
   818          memcpy(this_cpu_ptr(&current_brk), brk, sizeof(*brk));
   819  
 > 820          if (dawr_enabled())
   821                  // Power8 or later
   822                  set_dawr(brk);
   823          else if (!cpu_has_feature(CPU_FTR_ARCH_207S))
   824                  // Power7 or earlier
   825                  set_dabr(brk);
   826          else
   827                  // Shouldn't happen due to higher level checks
   828                  WARN_ON_ONCE(1);
   829  }
   830  

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip

Reply via email to