Hi Michael, On 21/02/19 4:43 PM, Michael Ellerman wrote: > Sandipan Das <sandi...@linux.ibm.com> writes: >> This enhances the current selftest framework for validating >> the in-kernel instruction emulation infrastructure by adding >> support for compute type instructions i.e. integer ALU-based >> instructions. Originally, this framework was limited to only >> testing load and store instructions. >> >> While most of the GPRs can be validated, support for SPRs is >> limited to LR, CR and XER for now. >> >> When writing the test cases, one must ensure that the Stack >> Pointer (GPR1) or the Thread Pointer (GPR13) are not touched >> by any means as these are vital non-volatile registers. >> >> Signed-off-by: Sandipan Das <sandi...@linux.ibm.com> >> --- >> arch/powerpc/lib/Makefile | 3 +- >> arch/powerpc/lib/test_emulate_step.c | 167 +++++++++++++++++- >> .../lib/test_emulate_step_exec_instr.S | 150 ++++++++++++++++ >> 3 files changed, 315 insertions(+), 5 deletions(-) >> create mode 100644 arch/powerpc/lib/test_emulate_step_exec_instr.S > > Hi Sandipan, > > Thanks for the exceptionally well written asm, I wish all our asm code > was that neat and well commented :) > > I'd like to get this merged today so I tweaked it slightly when > applying to use the new patch_site helpers we added recently, see diff > below. > > cheers > >
Thanks for modernizing it :) - Sandipan
