On Mon, Mar 17, 2008 at 4:28 PM, Wolfgang Denk <[EMAIL PROTECTED]> wrote: > In message <[EMAIL PROTECTED]> you wrote: > > * The TQM5200 configuration as provided is intended for shipping as > default configuration for this board. The "engineer responsible" > already *did* the tailoring and put that state in the defconfig > file. > > * The CM5200 and Motion-Pro boards are custom designs, where the > defconfig file matches exactly the requirements of the respective > customers. > > I feel it is very important to be able to include this configuration > information somewhere with the kernel source tree - and to me the > defconfig file for a board is the most natural place to put such > information.
(copied from my comments in an off-list conversation) However, I have declined (for now) to pick up the defconfigs for those boards and instead merged in the config features they require into the mpc5200 defconfig. My primary reason for doing so is to increase the likelyhood that full featured kernels are built and tested so that situations where board ports conflict with each other are caught and fixed. ojn has also been complaining about the number of defconfigs he needs to build to test all the powerpc configurations without any indications about which ones are important and which ones are not. There has been some discussion about having a subdirectory for optimized board configs, but nobody has done anything about it yet. The one part that I have a really strong opinion on is that there should be a full featured mpc5200 defconfig for build testing. Beyond that (and if ojn can also be appeased) I can probably be convinced. :-) > > All these boards are supported with > > arch/powerpc/platforms/mpc5200_simple.c. A kernel built for that > > platform will boot on any of those boards as long as it is passed the > > correct device tree. > > I don't doubt that the kernel will boot. But that does not mean that > it is ready for use for the intended purpose. For example, > arch/powerpc/platforms/52xx/motionpro.c contains code to setup some > custom LEDs on this board. I can't find that code in > > arch/powerpc/platforms/mpc5200_simple.c. > > It may be argued that this code should be moved somewhere else, but I > don't remeber to have seen any such review comments. The LED code just hasn't been picked up. IIRC, it was reworked to make it a proper driver in drivers/leds. I need to look at it again, but it is a lot of code for a very simple thing and I wasn't sure if I should be the one to pick it up because it is in drivers/leds which has a different maintainer. Cheers, g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
