Great, I'll do that. Does this also apply to my other patch, Adding 8250 console support to OF serial, as it's not clear to me when to assume the UART is already setup or not?
Thanks, John -----Original Message----- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Grant Likely Sent: Monday, March 17, 2008 2:08 PM To: John Linn Cc: linuxppc-dev@ozlabs.org; [EMAIL PROTECTED] Subject: Re: [PATCH] [POWERPC] Xilinx: Boot: Fix 16550 UART initialization On Mon, Mar 17, 2008 at 1:57 PM, John Linn <[EMAIL PROTECTED]> wrote: > That makes sense. Since I'm not using a boot loader I didn't realize > that. > > I'm not sure how hard it will be to get the data from the device tree at > that time. You should be good. It is now possible to read data from the device tree at platform_init() time. Cheers, g. > What about checking to see if it's setup assuming that's possible by > looking at registers, and then not messing with it if it's already > setup, otherwise do what my patch does. Ugh. The old arch/ppc code used to do this and it was kind of ugly and fragile. I'd rather avoid doing it again. Cheers, g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
