Arnd Bergmann <a...@arndb.de> writes: > On Mon, Jan 14, 2019 at 12:36 PM Michael Ellerman <m...@ellerman.id.au> wrote: >> >> We never pass a value for offset, nor do we need to, so remove the >> offset logic. >> >> Signed-off-by: Michael Ellerman <m...@ellerman.id.au> > > This change and the next three defeat the idea of having a shared script > across > all architectures.
The scripts are < 100 lines total, so sharing them across arches is really not much of a win. Especially if it requires compromising the format of the table on some architectures. Shoe horning the SPU visibility into the ABI field was a good hack but I really dislike it being the permanent state of our syscall table. > Firoz has already posted patches to move the scripts to scripts/syscalltbl.sh Those don't work for x86 AFAICS? > and I think it's better to go on with those patches, as they > also guarantee that the format of the files remains consistent across all > architectures. Why is that a requirement? Another possibility is that we have a separate file that stores the SPU visibility, that way our syscall.tbl would have the same format as other arches, and we could probably share the scripts, but we'd need our own script for generating the SPU table. I'll hack that up and see how it looks. cheers
