Am 2018-12-17 um 08:35 schrieb Christoph Hellwig: > On Mon, Dec 17, 2018 at 07:51:05AM +0100, Christophe Leroy wrote: >> >> >> Le 16/12/2018 à 18:19, Christoph Hellwig a écrit : >>> The implemementation for the CONFIG_NOT_COHERENT_CACHE case doesn't share >>> any code with the one for systems with coherent caches. Split it off >>> and merge it with the helpers in dma-noncoherent.c that have no other >>> callers. >>> >>> Signed-off-by: Christoph Hellwig <h...@lst.de> >>> Acked-by: Benjamin Herrenschmidt <b...@kernel.crashing.org> >>> --- >>> arch/powerpc/include/asm/dma-mapping.h | 5 ----- >>> arch/powerpc/kernel/dma.c | 14 ++------------ >> >> Instead of all the ifdefs in dma.c, couldn't we split it >> in two files, ie dma.c for common parts and dma-coherence.c for specific >> stuff ? > > The end goal is to kill dma.c and keep dma-noncoherent.c only with most > of the code moving to common code. Here is the current state of that: > > http://git.infradead.org/users/hch/misc.git/shortlog/refs/heads/powerpc-dma.5 > > But it still has issues on two tested platforms and isn't ready yet. I hope that I can give this a try on one of my AmigaOne machines over Christmas. Unfortunately my main local AmigaOne machine is out of order and the other one is only remotely accessible, which makes kernel testing a bit hard. :-)
Gerhard
