On (04/03/08 12:07), Christoph Lameter didst pronounce:
> I think this is the correct fix.
> 
> The NUMA fallback logic should be passing local_flags to kmem_get_pages() 
> and not simply the flags.
> 
> Maybe a stable candidate since we are now simply 
> passing on flags to the page allocator on the fallback path.
> 
> Signed-off-by: Christoph Lameter <[EMAIL PROTECTED]>

Acked-by: Mel Gorman <[EMAIL PROTECTED]>

Thanks Christoph.

> 
> ---
>  mm/slab.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Index: linux-2.6.25-rc3-mm1/mm/slab.c
> ===================================================================
> --- linux-2.6.25-rc3-mm1.orig/mm/slab.c       2008-03-04 12:01:07.430911920 
> -0800
> +++ linux-2.6.25-rc3-mm1/mm/slab.c    2008-03-04 12:04:54.449857145 -0800
> @@ -3277,7 +3277,7 @@ retry:
>               if (local_flags & __GFP_WAIT)
>                       local_irq_enable();
>               kmem_flagcheck(cache, flags);
> -             obj = kmem_getpages(cache, flags, -1);
> +             obj = kmem_getpages(cache, local_flags, -1);
>               if (local_flags & __GFP_WAIT)
>                       local_irq_disable();
>               if (obj) {
> 

-- 
Mel Gorman
Part-time Phd Student                          Linux Technology Center
University of Limerick                         IBM Dublin Software Lab
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev

Reply via email to