> -----Original Message-----
> From: devicetree-ow...@vger.kernel.org <devicetree-ow...@vger.kernel.org>
> On Behalf Of Stephen Boyd
> Sent: Monday, October 15, 2018 10:19 PM
> To: Shawn Guo <shawn...@kernel.org>; Vabhav Sharma
> <vabhav.sha...@nxp.com>
> Cc: sudeep.ho...@arm.com; o...@buserror.net; linux-ker...@vger.kernel.org;
> devicet...@vger.kernel.org; robh...@kernel.org; mark.rutl...@arm.com;
> linuxppc-dev@lists.ozlabs.org; linux-arm-ker...@lists.infradead.org;
> mturque...@baylibre.com; r...@rjwysocki.net; viresh.ku...@linaro.org;
> linux-...@vger.kernel.org; linux...@vger.kernel.org; linux-kernel-
> ow...@vger.kernel.org; catalin.mari...@arm.com; will.dea...@arm.com;
> gre...@linuxfoundation.org; a...@arndb.de;
> kstew...@linuxfoundation.org; yamada.masah...@socionext.com; Leo Li
> <leoyang...@nxp.com>; li...@armlinux.org.uk; Varun Sethi
> <v.se...@nxp.com>; Udit Kumar <udit.ku...@nxp.com>; Pankaj Bansal
> <pankaj.ban...@nxp.com>; Ramneek Mehresh
> <ramneek.mehr...@nxp.com>; Ying Zhang <ying.zhang22...@nxp.com>;
> Nipun Gupta <nipun.gu...@nxp.com>; Priyanka Jain
> <priyanka.j...@nxp.com>; Yogesh Narayan Gaur
> <yogeshnarayan.g...@nxp.com>; Sriram Dash <sriram.d...@nxp.com>
> Subject: RE: [PATCH v4 5/6] arm64: dts: add QorIQ LX2160A SoC support
>
> Quoting Vabhav Sharma (2018-10-14 19:58:15)
> > > > +
> > > > + pmu {
> > > > + compatible = "arm,cortex-a72-pmu";
> > > > + interrupts = <GIC_PPI 7 IRQ_TYPE_LEVEL_LOW>;
> > > > + };
> > > > +
> > > > + psci {
> > > > + compatible = "arm,psci-0.2";
> > > > + method = "smc";
> > > > + };
> > > > +
> > > > + memory@80000000 {
> > > > + // DRAM space - 1, size : 2 GB DRAM
> > > > + device_type = "memory";
> > > > + reg = <0x00000000 0x80000000 0 0x80000000>;
> > > > + };
> > > > +
> > > > + ddr1: memory-controller@1080000 {
> > > > + compatible = "fsl,qoriq-memory-controller";
> > > > + reg = <0x0 0x1080000 0x0 0x1000>;
> > > > + interrupts = <GIC_SPI 17 IRQ_TYPE_LEVEL_HIGH>;
> > > > + little-endian;
> > > > + };
> > > > +
> > > > + ddr2: memory-controller@1090000 {
> > > > + compatible = "fsl,qoriq-memory-controller";
> > > > + reg = <0x0 0x1090000 0x0 0x1000>;
> > > > + interrupts = <GIC_SPI 18 IRQ_TYPE_LEVEL_HIGH>;
> > > > + little-endian;
> > > > + };
> > > > +
> > > > + sysclk: sysclk {
> > >
> > > Name the node a bit generic like clock-xxx.
> > There is only one clock-unit, Bootloader(U-boot) require sysclk node during
> device tree fix-up as different platform support varied platform frequency as
> per reset configuration word used.
> > Referred other ARM based platform with one clock using name as x: x
>
> Please add a comment above this node with this information. Newcomers
> reading this DTS file won't have any idea why this node is specially named
> and a comment will help tremendously here.
Sure
