Segher Boessenkool <seg...@kernel.crashing.org> writes: > On Thu, Sep 20, 2018 at 03:29:22PM +0530, Madhavan Srinivasan wrote: >> On Thursday 20 September 2018 03:11 PM, Michael Ellerman wrote: >> >In power7_marked_instr_event() there is a switch case that is missing >> >a break or an explicit fallthrough, it's not immediately clear which >> >it should be. > >> Just curious to know, how did you find this. Static code checker compiled >> or any specific compiler warnings or just by code read? > > Newer GCC warns about suspicious fallthroughs (-Wimplicit-fallthrough, > which is in -Wextra).
Yeah I actually turned -Wimplicit-fallthrough on manually. I'm hoping to add that to our CFLAGS once I've merged this fix and worked out the Kbuild magic to add it to CFLAGS just for arch/powerpc. cheers
