On Thu, Feb 28, 2008 at 09:47:27PM +0300, Alexandr Smirnov wrote:
> +     [EMAIL PROTECTED] {
> +             #address-cells = <1>;
> +             #size-cells = <1>;
> +             device_type = "soc";
> +             ranges = <0x00000000 0xfdf00000 0x00100000>;
> +             reg = <0xfdf00000 0x200>;
The reg property is no longer needed here.

> +             [EMAIL PROTECTED] {                                     /* For 
> TSECs */
> +                     #address-cells = <1>;
> +                     #size-cells = <0>;
> +                     device_type = "mdio";
> +                     compatible = "gianfar";

No device_type, compatible should be "fsl,gianfar-mdio".

> +     [EMAIL PROTECTED] {
> +             #address-cells = <1>;
> +             #size-cells = <1>;
> +             compatible = "fsl,mpc8560-localbus";
> +             reg = <0xfdf05000 0x68>;
> +
> +             ranges = <0xe0000000 0xe0000000 0x00800000>;

The localbus node isn't just a container for flash; if you're not going to
use the chipselect mechanism (and you should), then at least use a blank
"ranges;".

> +     [EMAIL PROTECTED] {
> +             compatible = "altera,maxii";
> +             reg = <0xe8080000 0x80000>;
> +     };

Should this go under the localbus node?

-Scott
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev

Reply via email to