On Fri, 2018-08-10 at 12:25:35 UTC, Michael Ellerman wrote:
> Currently if you build a 32-bit powerpc kernel and use get_user() to
> load a u64 value it will fail to build with eg:
>
> kernel/rseq.o: In function `rseq_get_rseq_cs':
> kernel/rseq.c:123: undefined reference to `__get_user_bad'
>
> This is hitting the check in __get_user_size() that makes sure the
> size we're copying doesn't exceed the size of the destination:
>
> #define __get_user_size(x, ptr, size, retval)
> do {
> retval = 0;
> __chk_user_ptr(ptr);
> if (size > sizeof(x))
> (x) = __get_user_bad();
>
> Which doesn't immediately make sense because the size of the
> destination is u64, but it's not really, because __get_user_check()
> etc. internally create an unsigned long and copy into that:
>
> #define __get_user_check(x, ptr, size)
> ({
> long __gu_err = -EFAULT;
> unsigned long __gu_val = 0;
>
> The problem being that on 32-bit unsigned long is not big enough to
> hold a u64. We can fix this with a trick from hpa in the x86 code, we
> statically check the type of x and set the type of __gu_val to either
> unsigned long or unsigned long long.
>
> Signed-off-by: Michael Ellerman <m...@ellerman.id.au>
Applied to powerpc next.
https://git.kernel.org/powerpc/c/f7a6947cd49b7ff4e03f1b4f7e7b22
cheers
