I will update the header files 'of_private.h' and 'of.h' and repost. Michael
On 08/08/2018 10:37 AM, Michael Bringmann wrote: > On 08/08/2018 09:02 AM, Michael Ellerman wrote: >> Michael Bringmann <m...@linux.vnet.ibm.com> writes: >>> diff --git a/arch/powerpc/platforms/pseries/mobility.c >>> b/arch/powerpc/platforms/pseries/mobility.c >>> index e245a88..efc9442 100644 >>> --- a/arch/powerpc/platforms/pseries/mobility.c >>> +++ b/arch/powerpc/platforms/pseries/mobility.c >>> @@ -22,6 +22,9 @@ >>> #include <asm/rtas.h> >>> #include "pseries.h" >>> >>> +extern int of_free_phandle_cache(void); >>> +extern void of_populate_phandle_cache(void); >> >> We don't do that, they should be in a header. >> >> But that's a minor problem given that the patch doesn't compile, because >> both those functions are static. > > I am building against the latest 'linux-ppc' kernel. It includes patch > > Commit b9952b5218added5577e4a3443969bc20884cea9 Mon Sep 17 00:00:00 2001 > From: Frank Rowand <frank.row...@sony.com> > Date: Thu, 12 Jul 2018 14:00:07 -0700 > Subject: of: overlay: update phandle cache on overlay apply and remove > > which makes the functions static. I will rebuild and test with an > earlier version if you will specify which one. > >> >> Presumably you have a hack in your tree to make them non-static? >> Please try and compile your patches in a clean tree before sending. >> >> cheers > > Regards, > Michael > -- Michael W. Bringmann Linux Technology Center IBM Corporation Tie-Line 363-5196 External: (512) 286-5196 Cell: (512) 466-0650 m...@linux.vnet.ibm.com
