On Thu, 12 Jul 2018 15:46:06 +1000 Michael Ellerman <m...@ellerman.id.au> wrote:
> Daniel Klamt <el...@ele0n.de> writes: > > > Replaced msleep(x) with with msleep(OPAL_BUSY_DELAY_MS) > > to diocument these sleep is to wait for opal. > > > > Signed-off-by: Daniel Klamt <el...@ele0n.de> > > Signed-off-by: Bjoern Noetel <bjo...@br3ak3r.de> > > Thanks. > > Your change log should be in the imperative mood, see: > > > https://git.kernel.org/pub/scm/git/git.git/tree/Documentation/SubmittingPatches?id=HEAD#n133 > > > In this case that just means saying "Replace" rather than "Replaced". > > Also the prefix should be "powerpc/xive". You can guess that by doing: > > $ git log --oneline arch/powerpc/sysdev/xive/native.c > > And notice that the majority of commits use that prefix. > > > I've fixed both of those things up for you. Sorry, just noticed this. I've got a patch which changes the xive stuff to the "standard" format this will clash with. if (rc == OPAL_BUSY_EVENT) { msleep(OPAL_BUSY_DELAY_MS); opal_poll_events(NULL); } else if (rc == OPAL_BUSY) { msleep(OPAL_BUSY_DELAY_MS); } If it's already merged that's fine, I can rebase. Thanks, Nick
