Hi Michael,
Hi All,
kbuild test robot Wed, 03 Jan 2018 04:17:20 -0800 wrote:
Hi Darren,
Thank you for the patch! Perhaps something to improve:
arch/powerpc/platforms/pasemi/pci.c: In function 'sb600_set_flag': >>
include/linux/kern_levels.h:5:18: warning: format '%lx' expects argument of >>
type 'long unsigned int', but argument 2 has type 'resource_size_t {aka long >>
long unsigned int}' [-Wformat=] #define KERN_SOH "\001" /* ASCII Start Of
Header */
—-
I was able to fix this small format issue. I replaced the format '%08lx' with
'%08llx'.
+ printk(KERN_CRIT "NEMO SB600 IOB base %08llx\n",res.start);
Is this fix OK or is there a better solution?
> On 3. May 2018, at 15:06, Michael Ellerman <m...@ellerman.id.au> wrote:
>
>> +
>> + printk(KERN_CRIT "NEMO SB600 IOB base %08lx\n",res.start);
>
> That's INFO or even DEBUG.
>>
Michael,
What do you think about this fix?
+ printk(KERN_INFO "NEMO SB600 IOB base %08llx\n",res.start);
Thanks,
Christian
