RE: [PATCH] QE GPIO: Add qe_gpio_set_multiple

[Qiang Zhao]

On 06/19/2018 09:22 AM, Joakim Tjernlund wrote:
-----Original Message-----
From: Linuxppc-dev 
[mailto:linuxppc-dev-bounces+qiang.zhao=nxp....@lists.ozlabs.org] On Behalf Of 
Joakim Tjernlund
Sent: 2018年6月20日 0:22
To: York Sun <york....@nxp.com>; linuxppc-dev <linuxppc-dev@lists.ozlabs.org>
Subject: [PATCH] QE GPIO: Add qe_gpio_set_multiple

This cousin to gpio-mpc8xxx was lacking a multiple pins method, add one.

Signed-off-by: Joakim Tjernlund <joakim.tjernl...@infinera.com>
---
 drivers/soc/fsl/qe/gpio.c | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/drivers/soc/fsl/qe/gpio.c b/drivers/soc/fsl/qe/gpio.c index 
3b27075c21a7..819bed0f5667 100644
--- a/drivers/soc/fsl/qe/gpio.c
+++ b/drivers/soc/fsl/qe/gpio.c
@@ -83,6 +83,33 @@ static void qe_gpio_set(struct gpio_chip *gc, unsigned int 
gpio, int val)
        spin_unlock_irqrestore(&qe_gc->lock, flags);  }
 
+static void qe_gpio_set_multiple(struct gpio_chip *gc,
+                                unsigned long *mask, unsigned long *bits) {
+       struct of_mm_gpio_chip *mm_gc = to_of_mm_gpio_chip(gc);
+       struct qe_gpio_chip *qe_gc = gpiochip_get_data(gc);
+       struct qe_pio_regs __iomem *regs = mm_gc->regs;
+       unsigned long flags;
+       int i;
+
+       spin_lock_irqsave(&qe_gc->lock, flags);
+
+       for (i = 0; i < gc->ngpio; i++) {
+               if (*mask == 0)
+                       break;
+               if (__test_and_clear_bit(i, mask)) {
+                       if (test_bit(i, bits))
+                               qe_gc->cpdata |= (1U << (QE_PIO_PINS - 1 - i));
+                       else
+                               qe_gc->cpdata &= ~(1U << (QE_PIO_PINS - 1 - i));
+               }
+       }
+
+       out_be32(&regs->cpdata, qe_gc->cpdata);
+
+       spin_unlock_irqrestore(&qe_gc->lock, flags); }
+
 static int qe_gpio_dir_in(struct gpio_chip *gc, unsigned int gpio)  {
        struct of_mm_gpio_chip *mm_gc = to_of_mm_gpio_chip(gc); @@ -298,6 
+325,7 @@ static int __init qe_add_gpiochips(void)
                gc->direction_output = qe_gpio_dir_out;
                gc->get = qe_gpio_get;
                gc->set = qe_gpio_set;
+               gc->set_multiple = qe_gpio_set_multiple;
 
                ret = of_mm_gpiochip_add_data(np, mm_gc, qe_gc);
                if (ret)

Reviewed-by: Qiang Zhao <qiang.z...@nxp.com>