Hi Nicholas, I love your patch! Yet something to improve:
[auto build test ERROR on powerpc/next] [also build test ERROR on next-20180613] [cannot apply to v4.17] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Nicholas-Piggin/powerpc-64s-radix-Fix-MADV_-FREE-DONTNEED-TLB-flush-miss-problem-with-THP/20180614-114728 base: https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git next config: microblaze-nommu_defconfig (attached as .config) compiler: microblaze-linux-gcc (GCC) 8.1.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree GCC_VERSION=8.1.0 make.cross ARCH=microblaze All errors (new ones prefixed by >>): In file included from include/linux/mm.h:478, from arch/microblaze/include/asm/io.h:17, from include/linux/clocksource.h:21, from include/linux/clockchips.h:14, from include/linux/tick.h:8, from include/linux/sched/isolation.h:6, from kernel/sched/sched.h:17, from kernel/sched/loadavg.c:9: include/linux/migrate.h: In function 'new_page_nodemask': >> include/linux/huge_mm.h:82:25: error: 'PMD_SHIFT' undeclared (first use in >> this function); did you mean 'NMI_SHIFT'? #define HPAGE_PMD_SHIFT PMD_SHIFT ^~~~~~~~~ include/linux/huge_mm.h:79:26: note: in expansion of macro 'HPAGE_PMD_SHIFT' #define HPAGE_PMD_ORDER (HPAGE_PMD_SHIFT-PAGE_SHIFT) ^~~~~~~~~~~~~~~ include/linux/migrate.h:47:11: note: in expansion of macro 'HPAGE_PMD_ORDER' order = HPAGE_PMD_ORDER; ^~~~~~~~~~~~~~~ include/linux/huge_mm.h:82:25: note: each undeclared identifier is reported only once for each function it appears in #define HPAGE_PMD_SHIFT PMD_SHIFT ^~~~~~~~~ include/linux/huge_mm.h:79:26: note: in expansion of macro 'HPAGE_PMD_SHIFT' #define HPAGE_PMD_ORDER (HPAGE_PMD_SHIFT-PAGE_SHIFT) ^~~~~~~~~~~~~~~ include/linux/migrate.h:47:11: note: in expansion of macro 'HPAGE_PMD_ORDER' order = HPAGE_PMD_ORDER; ^~~~~~~~~~~~~~~ -- In file included from include/linux/mm.h:478, from arch/microblaze/include/asm/io.h:17, from include/linux/clocksource.h:21, from include/linux/clockchips.h:14, from include/linux/tick.h:8, from include/linux/sched/isolation.h:6, from kernel/sched/sched.h:17, from kernel/sched/core.c:8: include/linux/migrate.h: In function 'new_page_nodemask': >> include/linux/huge_mm.h:82:25: error: 'PMD_SHIFT' undeclared (first use in >> this function); did you mean 'NMI_SHIFT'? #define HPAGE_PMD_SHIFT PMD_SHIFT ^~~~~~~~~ include/linux/huge_mm.h:79:26: note: in expansion of macro 'HPAGE_PMD_SHIFT' #define HPAGE_PMD_ORDER (HPAGE_PMD_SHIFT-PAGE_SHIFT) ^~~~~~~~~~~~~~~ include/linux/migrate.h:47:11: note: in expansion of macro 'HPAGE_PMD_ORDER' order = HPAGE_PMD_ORDER; ^~~~~~~~~~~~~~~ include/linux/huge_mm.h:82:25: note: each undeclared identifier is reported only once for each function it appears in #define HPAGE_PMD_SHIFT PMD_SHIFT ^~~~~~~~~ include/linux/huge_mm.h:79:26: note: in expansion of macro 'HPAGE_PMD_SHIFT' #define HPAGE_PMD_ORDER (HPAGE_PMD_SHIFT-PAGE_SHIFT) ^~~~~~~~~~~~~~~ include/linux/migrate.h:47:11: note: in expansion of macro 'HPAGE_PMD_ORDER' order = HPAGE_PMD_ORDER; ^~~~~~~~~~~~~~~ In file included from kernel/sched/sched.h:63, from kernel/sched/core.c:8: kernel/sched/core.c: At top level: include/linux/syscalls.h:233:18: warning: 'sys_sched_rr_get_interval' alias between functions of incompatible types 'long int(pid_t, struct timespec *)' {aka 'long int(int, struct timespec *)'} and 'long int(long int, long int)' [-Wattribute-alias] asmlinkage long sys##name(__MAP(x,__SC_DECL,__VA_ARGS__)) \ ^~~ include/linux/syscalls.h:222:2: note: in expansion of macro '__SYSCALL_DEFINEx' __SYSCALL_DEFINEx(x, sname, __VA_ARGS__) ^~~~~~~~~~~~~~~~~ include/linux/syscalls.h:212:36: note: in expansion of macro 'SYSCALL_DEFINEx' #define SYSCALL_DEFINE2(name, ...) SYSCALL_DEFINEx(2, _##name, __VA_ARGS__) ^~~~~~~~~~~~~~~ kernel/sched/core.c:5274:1: note: in expansion of macro 'SYSCALL_DEFINE2' SYSCALL_DEFINE2(sched_rr_get_interval, pid_t, pid, ^~~~~~~~~~~~~~~ include/linux/syscalls.h:238:18: note: aliased declaration here asmlinkage long __se_sys##name(__MAP(x,__SC_LONG,__VA_ARGS__)) \ ^~~~~~~~ include/linux/syscalls.h:222:2: note: in expansion of macro '__SYSCALL_DEFINEx' __SYSCALL_DEFINEx(x, sname, __VA_ARGS__) ^~~~~~~~~~~~~~~~~ include/linux/syscalls.h:212:36: note: in expansion of macro 'SYSCALL_DEFINEx' #define SYSCALL_DEFINE2(name, ...) SYSCALL_DEFINEx(2, _##name, __VA_ARGS__) ^~~~~~~~~~~~~~~ kernel/sched/core.c:5274:1: note: in expansion of macro 'SYSCALL_DEFINE2' SYSCALL_DEFINE2(sched_rr_get_interval, pid_t, pid, ^~~~~~~~~~~~~~~ include/linux/syscalls.h:233:18: warning: 'sys_sched_getaffinity' alias between functions of incompatible types 'long int(pid_t, unsigned int, long unsigned int *)' {aka 'long int(int, unsigned int, long unsigned int *)'} and 'long int(long int, long int, long int)' [-Wattribute-alias] asmlinkage long sys##name(__MAP(x,__SC_DECL,__VA_ARGS__)) \ ^~~ include/linux/syscalls.h:222:2: note: in expansion of macro '__SYSCALL_DEFINEx' __SYSCALL_DEFINEx(x, sname, __VA_ARGS__) ^~~~~~~~~~~~~~~~~ include/linux/syscalls.h:213:36: note: in expansion of macro 'SYSCALL_DEFINEx' #define SYSCALL_DEFINE3(name, ...) SYSCALL_DEFINEx(3, _##name, __VA_ARGS__) ^~~~~~~~~~~~~~~ kernel/sched/core.c:4909:1: note: in expansion of macro 'SYSCALL_DEFINE3' SYSCALL_DEFINE3(sched_getaffinity, pid_t, pid, unsigned int, len, ^~~~~~~~~~~~~~~ include/linux/syscalls.h:238:18: note: aliased declaration here asmlinkage long __se_sys##name(__MAP(x,__SC_LONG,__VA_ARGS__)) \ ^~~~~~~~ include/linux/syscalls.h:222:2: note: in expansion of macro '__SYSCALL_DEFINEx' __SYSCALL_DEFINEx(x, sname, __VA_ARGS__) ^~~~~~~~~~~~~~~~~ include/linux/syscalls.h:213:36: note: in expansion of macro 'SYSCALL_DEFINEx' #define SYSCALL_DEFINE3(name, ...) SYSCALL_DEFINEx(3, _##name, __VA_ARGS__) ^~~~~~~~~~~~~~~ kernel/sched/core.c:4909:1: note: in expansion of macro 'SYSCALL_DEFINE3' SYSCALL_DEFINE3(sched_getaffinity, pid_t, pid, unsigned int, len, ^~~~~~~~~~~~~~~ include/linux/syscalls.h:233:18: warning: 'sys_sched_setaffinity' alias between functions of incompatible types 'long int(pid_t, unsigned int, long unsigned int *)' {aka 'long int(int, unsigned int, long unsigned int *)'} and 'long int(long int, long int, long int)' [-Wattribute-alias] asmlinkage long sys##name(__MAP(x,__SC_DECL,__VA_ARGS__)) \ ^~~ include/linux/syscalls.h:222:2: note: in expansion of macro '__SYSCALL_DEFINEx' __SYSCALL_DEFINEx(x, sname, __VA_ARGS__) ^~~~~~~~~~~~~~~~~ include/linux/syscalls.h:213:36: note: in expansion of macro 'SYSCALL_DEFINEx' #define SYSCALL_DEFINE3(name, ...) SYSCALL_DEFINEx(3, _##name, __VA_ARGS__) ^~~~~~~~~~~~~~~ kernel/sched/core.c:4857:1: note: in expansion of macro 'SYSCALL_DEFINE3' SYSCALL_DEFINE3(sched_setaffinity, pid_t, pid, unsigned int, len, ^~~~~~~~~~~~~~~ include/linux/syscalls.h:238:18: note: aliased declaration here asmlinkage long __se_sys##name(__MAP(x,__SC_LONG,__VA_ARGS__)) \ ^~~~~~~~ include/linux/syscalls.h:222:2: note: in expansion of macro '__SYSCALL_DEFINEx' __SYSCALL_DEFINEx(x, sname, __VA_ARGS__) ^~~~~~~~~~~~~~~~~ include/linux/syscalls.h:213:36: note: in expansion of macro 'SYSCALL_DEFINEx' #define SYSCALL_DEFINE3(name, ...) SYSCALL_DEFINEx(3, _##name, __VA_ARGS__) ^~~~~~~~~~~~~~~ kernel/sched/core.c:4857:1: note: in expansion of macro 'SYSCALL_DEFINE3' SYSCALL_DEFINE3(sched_setaffinity, pid_t, pid, unsigned int, len, ^~~~~~~~~~~~~~~ include/linux/syscalls.h:233:18: warning: 'sys_sched_getattr' alias between functions of incompatible types 'long int(pid_t, struct sched_attr *, unsigned int, unsigned int)' {aka 'long int(int, struct sched_attr *, unsigned int, unsigned int)'} and 'long int(long int, long int, long int, long int)' [-Wattribute-alias] asmlinkage long sys##name(__MAP(x,__SC_DECL,__VA_ARGS__)) \ ^~~ include/linux/syscalls.h:222:2: note: in expansion of macro '__SYSCALL_DEFINEx' __SYSCALL_DEFINEx(x, sname, __VA_ARGS__) ^~~~~~~~~~~~~~~~~ include/linux/syscalls.h:214:36: note: in expansion of macro 'SYSCALL_DEFINEx' #define SYSCALL_DEFINE4(name, ...) SYSCALL_DEFINEx(4, _##name, __VA_ARGS__) -- In file included from include/linux/mm.h:478, from arch/microblaze/include/asm/io.h:17, from include/linux/clocksource.h:21, from include/linux/clockchips.h:14, from include/linux/tick.h:8, from include/linux/sched/isolation.h:6, from kernel//sched/sched.h:17, from kernel//sched/core.c:8: include/linux/migrate.h: In function 'new_page_nodemask': >> include/linux/huge_mm.h:82:25: error: 'PMD_SHIFT' undeclared (first use in >> this function); did you mean 'NMI_SHIFT'? #define HPAGE_PMD_SHIFT PMD_SHIFT ^~~~~~~~~ include/linux/huge_mm.h:79:26: note: in expansion of macro 'HPAGE_PMD_SHIFT' #define HPAGE_PMD_ORDER (HPAGE_PMD_SHIFT-PAGE_SHIFT) ^~~~~~~~~~~~~~~ include/linux/migrate.h:47:11: note: in expansion of macro 'HPAGE_PMD_ORDER' order = HPAGE_PMD_ORDER; ^~~~~~~~~~~~~~~ include/linux/huge_mm.h:82:25: note: each undeclared identifier is reported only once for each function it appears in #define HPAGE_PMD_SHIFT PMD_SHIFT ^~~~~~~~~ include/linux/huge_mm.h:79:26: note: in expansion of macro 'HPAGE_PMD_SHIFT' #define HPAGE_PMD_ORDER (HPAGE_PMD_SHIFT-PAGE_SHIFT) ^~~~~~~~~~~~~~~ include/linux/migrate.h:47:11: note: in expansion of macro 'HPAGE_PMD_ORDER' order = HPAGE_PMD_ORDER; ^~~~~~~~~~~~~~~ In file included from kernel//sched/sched.h:63, from kernel//sched/core.c:8: kernel//sched/core.c: At top level: include/linux/syscalls.h:233:18: warning: 'sys_sched_rr_get_interval' alias between functions of incompatible types 'long int(pid_t, struct timespec *)' {aka 'long int(int, struct timespec *)'} and 'long int(long int, long int)' [-Wattribute-alias] asmlinkage long sys##name(__MAP(x,__SC_DECL,__VA_ARGS__)) \ ^~~ include/linux/syscalls.h:222:2: note: in expansion of macro '__SYSCALL_DEFINEx' __SYSCALL_DEFINEx(x, sname, __VA_ARGS__) ^~~~~~~~~~~~~~~~~ include/linux/syscalls.h:212:36: note: in expansion of macro 'SYSCALL_DEFINEx' #define SYSCALL_DEFINE2(name, ...) SYSCALL_DEFINEx(2, _##name, __VA_ARGS__) ^~~~~~~~~~~~~~~ kernel//sched/core.c:5274:1: note: in expansion of macro 'SYSCALL_DEFINE2' SYSCALL_DEFINE2(sched_rr_get_interval, pid_t, pid, ^~~~~~~~~~~~~~~ include/linux/syscalls.h:238:18: note: aliased declaration here asmlinkage long __se_sys##name(__MAP(x,__SC_LONG,__VA_ARGS__)) \ ^~~~~~~~ include/linux/syscalls.h:222:2: note: in expansion of macro '__SYSCALL_DEFINEx' __SYSCALL_DEFINEx(x, sname, __VA_ARGS__) ^~~~~~~~~~~~~~~~~ include/linux/syscalls.h:212:36: note: in expansion of macro 'SYSCALL_DEFINEx' #define SYSCALL_DEFINE2(name, ...) SYSCALL_DEFINEx(2, _##name, __VA_ARGS__) ^~~~~~~~~~~~~~~ kernel//sched/core.c:5274:1: note: in expansion of macro 'SYSCALL_DEFINE2' SYSCALL_DEFINE2(sched_rr_get_interval, pid_t, pid, ^~~~~~~~~~~~~~~ include/linux/syscalls.h:233:18: warning: 'sys_sched_getaffinity' alias between functions of incompatible types 'long int(pid_t, unsigned int, long unsigned int *)' {aka 'long int(int, unsigned int, long unsigned int *)'} and 'long int(long int, long int, long int)' [-Wattribute-alias] asmlinkage long sys##name(__MAP(x,__SC_DECL,__VA_ARGS__)) \ ^~~ include/linux/syscalls.h:222:2: note: in expansion of macro '__SYSCALL_DEFINEx' __SYSCALL_DEFINEx(x, sname, __VA_ARGS__) ^~~~~~~~~~~~~~~~~ include/linux/syscalls.h:213:36: note: in expansion of macro 'SYSCALL_DEFINEx' #define SYSCALL_DEFINE3(name, ...) SYSCALL_DEFINEx(3, _##name, __VA_ARGS__) ^~~~~~~~~~~~~~~ kernel//sched/core.c:4909:1: note: in expansion of macro 'SYSCALL_DEFINE3' SYSCALL_DEFINE3(sched_getaffinity, pid_t, pid, unsigned int, len, ^~~~~~~~~~~~~~~ include/linux/syscalls.h:238:18: note: aliased declaration here asmlinkage long __se_sys##name(__MAP(x,__SC_LONG,__VA_ARGS__)) \ ^~~~~~~~ include/linux/syscalls.h:222:2: note: in expansion of macro '__SYSCALL_DEFINEx' __SYSCALL_DEFINEx(x, sname, __VA_ARGS__) ^~~~~~~~~~~~~~~~~ include/linux/syscalls.h:213:36: note: in expansion of macro 'SYSCALL_DEFINEx' #define SYSCALL_DEFINE3(name, ...) SYSCALL_DEFINEx(3, _##name, __VA_ARGS__) ^~~~~~~~~~~~~~~ kernel//sched/core.c:4909:1: note: in expansion of macro 'SYSCALL_DEFINE3' SYSCALL_DEFINE3(sched_getaffinity, pid_t, pid, unsigned int, len, ^~~~~~~~~~~~~~~ include/linux/syscalls.h:233:18: warning: 'sys_sched_setaffinity' alias between functions of incompatible types 'long int(pid_t, unsigned int, long unsigned int *)' {aka 'long int(int, unsigned int, long unsigned int *)'} and 'long int(long int, long int, long int)' [-Wattribute-alias] asmlinkage long sys##name(__MAP(x,__SC_DECL,__VA_ARGS__)) \ ^~~ include/linux/syscalls.h:222:2: note: in expansion of macro '__SYSCALL_DEFINEx' __SYSCALL_DEFINEx(x, sname, __VA_ARGS__) ^~~~~~~~~~~~~~~~~ include/linux/syscalls.h:213:36: note: in expansion of macro 'SYSCALL_DEFINEx' #define SYSCALL_DEFINE3(name, ...) SYSCALL_DEFINEx(3, _##name, __VA_ARGS__) ^~~~~~~~~~~~~~~ kernel//sched/core.c:4857:1: note: in expansion of macro 'SYSCALL_DEFINE3' SYSCALL_DEFINE3(sched_setaffinity, pid_t, pid, unsigned int, len, ^~~~~~~~~~~~~~~ include/linux/syscalls.h:238:18: note: aliased declaration here asmlinkage long __se_sys##name(__MAP(x,__SC_LONG,__VA_ARGS__)) \ ^~~~~~~~ include/linux/syscalls.h:222:2: note: in expansion of macro '__SYSCALL_DEFINEx' __SYSCALL_DEFINEx(x, sname, __VA_ARGS__) ^~~~~~~~~~~~~~~~~ include/linux/syscalls.h:213:36: note: in expansion of macro 'SYSCALL_DEFINEx' #define SYSCALL_DEFINE3(name, ...) SYSCALL_DEFINEx(3, _##name, __VA_ARGS__) ^~~~~~~~~~~~~~~ kernel//sched/core.c:4857:1: note: in expansion of macro 'SYSCALL_DEFINE3' SYSCALL_DEFINE3(sched_setaffinity, pid_t, pid, unsigned int, len, ^~~~~~~~~~~~~~~ include/linux/syscalls.h:233:18: warning: 'sys_sched_getattr' alias between functions of incompatible types 'long int(pid_t, struct sched_attr *, unsigned int, unsigned int)' {aka 'long int(int, struct sched_attr *, unsigned int, unsigned int)'} and 'long int(long int, long int, long int, long int)' [-Wattribute-alias] asmlinkage long sys##name(__MAP(x,__SC_DECL,__VA_ARGS__)) \ ^~~ include/linux/syscalls.h:222:2: note: in expansion of macro '__SYSCALL_DEFINEx' __SYSCALL_DEFINEx(x, sname, __VA_ARGS__) ^~~~~~~~~~~~~~~~~ include/linux/syscalls.h:214:36: note: in expansion of macro 'SYSCALL_DEFINEx' #define SYSCALL_DEFINE4(name, ...) SYSCALL_DEFINEx(4, _##name, __VA_ARGS__) vim +82 include/linux/huge_mm.h d8c37c48 Naoya Horiguchi 2012-03-21 81 fde52796 Aneesh Kumar K.V 2013-06-05 @82 #define HPAGE_PMD_SHIFT PMD_SHIFT fde52796 Aneesh Kumar K.V 2013-06-05 83 #define HPAGE_PMD_SIZE ((1UL) << HPAGE_PMD_SHIFT) fde52796 Aneesh Kumar K.V 2013-06-05 84 #define HPAGE_PMD_MASK (~(HPAGE_PMD_SIZE - 1)) 71e3aac0 Andrea Arcangeli 2011-01-13 85 :::::: The code at line 82 was first introduced by commit :::::: fde52796d487b675cde55427e3347ff3e59f9a7f mm/THP: don't use HPAGE_SHIFT in transparent hugepage code :::::: TO: Aneesh Kumar K.V <aneesh.ku...@linux.vnet.ibm.com> :::::: CC: Benjamin Herrenschmidt <b...@kernel.crashing.org> --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
