This is a note to let you know that I've just added the patch titled powerpc/pseries: Set or clear security feature flags
to the 4.16-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: powerpc-pseries-set-or-clear-security-feature-flags.patch and it can be found in the queue-4.16 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let <sta...@vger.kernel.org> know about it. >From foo@baz Wed May 23 19:18:22 CEST 2018 From: Michael Ellerman <m...@ellerman.id.au> Date: Wed, 23 May 2018 00:41:15 +1000 Subject: powerpc/pseries: Set or clear security feature flags To: g...@kroah.com Cc: sta...@vger.kernel.org, t...@linutronix.de, linuxppc-...@ozlabs.org Message-ID: <20180522144125.10345-5-...@ellerman.id.au> From: Michael Ellerman <m...@ellerman.id.au> commit f636c14790ead6cc22cf62279b1f8d7e11a67116 upstream. Now that we have feature flags for security related things, set or clear them based on what we receive from the hypercall. Signed-off-by: Michael Ellerman <m...@ellerman.id.au> Signed-off-by: Greg Kroah-Hartman <gre...@linuxfoundation.org> --- arch/powerpc/platforms/pseries/setup.c | 43 +++++++++++++++++++++++++++++++++ 1 file changed, 43 insertions(+) --- a/arch/powerpc/platforms/pseries/setup.c +++ b/arch/powerpc/platforms/pseries/setup.c @@ -68,6 +68,7 @@ #include <asm/plpar_wrappers.h> #include <asm/kexec.h> #include <asm/isa-bridge.h> +#include <asm/security_features.h> #include "pseries.h" @@ -459,6 +460,40 @@ static void __init find_and_init_phbs(vo of_pci_check_probe_only(); } +static void init_cpu_char_feature_flags(struct h_cpu_char_result *result) +{ + if (result->character & H_CPU_CHAR_SPEC_BAR_ORI31) + security_ftr_set(SEC_FTR_SPEC_BAR_ORI31); + + if (result->character & H_CPU_CHAR_BCCTRL_SERIALISED) + security_ftr_set(SEC_FTR_BCCTRL_SERIALISED); + + if (result->character & H_CPU_CHAR_L1D_FLUSH_ORI30) + security_ftr_set(SEC_FTR_L1D_FLUSH_ORI30); + + if (result->character & H_CPU_CHAR_L1D_FLUSH_TRIG2) + security_ftr_set(SEC_FTR_L1D_FLUSH_TRIG2); + + if (result->character & H_CPU_CHAR_L1D_THREAD_PRIV) + security_ftr_set(SEC_FTR_L1D_THREAD_PRIV); + + if (result->character & H_CPU_CHAR_COUNT_CACHE_DISABLED) + security_ftr_set(SEC_FTR_COUNT_CACHE_DISABLED); + + /* + * The features below are enabled by default, so we instead look to see + * if firmware has *disabled* them, and clear them if so. + */ + if (!(result->character & H_CPU_BEHAV_FAVOUR_SECURITY)) + security_ftr_clear(SEC_FTR_FAVOUR_SECURITY); + + if (!(result->character & H_CPU_BEHAV_L1D_FLUSH_PR)) + security_ftr_clear(SEC_FTR_L1D_FLUSH_PR); + + if (!(result->character & H_CPU_BEHAV_BNDS_CHK_SPEC_BAR)) + security_ftr_clear(SEC_FTR_BNDS_CHK_SPEC_BAR); +} + static void pseries_setup_rfi_flush(void) { struct h_cpu_char_result result; @@ -472,6 +507,8 @@ static void pseries_setup_rfi_flush(void rc = plpar_get_cpu_characteristics(&result); if (rc == H_SUCCESS) { + init_cpu_char_feature_flags(&result); + if (result.character & H_CPU_CHAR_L1D_FLUSH_TRIG2) types |= L1D_FLUSH_MTTRIG; if (result.character & H_CPU_CHAR_L1D_FLUSH_ORI30) @@ -482,6 +519,12 @@ static void pseries_setup_rfi_flush(void enable = false; } + /* + * We're the guest so this doesn't apply to us, clear it to simplify + * handling of it elsewhere. + */ + security_ftr_clear(SEC_FTR_L1D_FLUSH_HV); + setup_rfi_flush(types, enable); } Patches currently in stable-queue which might be from m...@ellerman.id.au are queue-4.16/powerpc-pseries-fix-clearing-of-security-feature-flags.patch queue-4.16/powerpc-powernv-set-or-clear-security-feature-flags.patch queue-4.16/powerpc-64s-move-cpu_show_meltdown.patch queue-4.16/powerpc-pseries-set-or-clear-security-feature-flags.patch queue-4.16/powerpc-move-default-security-feature-flags.patch queue-4.16/powerpc-powernv-use-the-security-flags-in-pnv_setup_rfi_flush.patch queue-4.16/powerpc-add-security-feature-flags-for-spectre-meltdown.patch queue-4.16/powerpc-pseries-use-the-security-flags-in-pseries_setup_rfi_flush.patch queue-4.16/powerpc-64s-enhance-the-information-in-cpu_show_meltdown.patch queue-4.16/powerpc-rfi-flush-always-enable-fallback-flush-on-pseries.patch queue-4.16/powerpc-pseries-add-new-h_get_cpu_characteristics-flags.patch queue-4.16/powerpc-64s-add-support-for-a-store-forwarding-barrier-at-kernel-entry-exit.patch queue-4.16/powerpc-64s-wire-up-cpu_show_spectre_v1.patch queue-4.16/powerpc-64s-wire-up-cpu_show_spectre_v2.patch