Stewart Smith <stew...@linux.vnet.ibm.com> writes: ... > > Slightly stupid question: should we be disabling these here or should > Linux be better and deciding what states to use? > > I'm inclined to say this is a Linux problem as it should make the > decision of what hardware feature to used based on the ones OPAL says > *can* be used.
Yeah I agree. Firmware shouldn't be implementing the policy around what states to use, it should tell the operating system (which might be Linux) what states are available and what their features are. The exception to that would be that we have unfixable crash bugs in existing kernels, in that case firmware might have to filter out states that are known to cause those. cheers
