On Thu, Apr 5, 2018 at 5:43 AM, Oliver <ooh...@gmail.com> wrote: > On Thu, Apr 5, 2018 at 10:11 PM, Michael Ellerman <m...@ellerman.id.au> wrote: >> Oliver <ooh...@gmail.com> writes: >> ... >>> >>> For context Balbir is working with me on some of the pmem stuff. You >>> probably want an Ack from Rob rather than one of us. >> >> I'll ack it if you make all the niggly nit picky trivial annoying >> changes I asked for :D > > *groan* > > Fine, I'll respin it tomorrow. If anyone else has comments now would > be the time to make them.
Please also include my niggly nit picky trivial annoying bike shed color for the driver name to *not* use the "nd_region" suffix for a driver registering "nvdimm_bus" objects. "of_pmem_range" or "of_pmem_bus" or almost anything else would be fine.