For now, if we can leave this patch as is, that will be great. That move 
requires me 
to work all remaining patches as they apply uncleanly after that.

I will bunch those two together functionally next time onwards.

Thanks,
Manish


Stephen Rothwell wrote:
> Hi Manish,
> 
>> -    /* Is there dump data waiting for us? */
>> +    /* Is there dump data waiting for us? If there isn't,
>> +     * then register a new dump area, and release all of
>> +     * the rest of the reserved ram.
>> +     *
>> +     * The /rtas/ibm,kernel-dump rtas node is present only
>> +     * if there is dump data waiting for us.
>> +     */
>>      rtas = of_find_node_by_path("/rtas");
>>      dump_header = of_get_property(rtas, "ibm,kernel-dump", &header_len);
>> +    of_node_put(rtas);
> 
> Oh, here is the of_node_put() - you should move that to patch 3.
> 

_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev

Reply via email to