Re: [PATCH v2 19/38] cxlflash: Support AFU state toggling

[Frederic Barrat]

Le 26/02/2018 à 23:22, Uma Krishnan a écrit :

The AFU should be enabled following a successful configuration and
disabled near the end of the cleanup path.

Signed-off-by: Uma Krishnan <ukri...@linux.vnet.ibm.com>
Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com>
---

Reviewed-by: Frederic Barrat <fbar...@linux.vnet.ibm.com>

  drivers/scsi/cxlflash/ocxl_hw.c | 9 +++++++++
  1 file changed, 9 insertions(+)

diff --git a/drivers/scsi/cxlflash/ocxl_hw.c b/drivers/scsi/cxlflash/ocxl_hw.c
index 67f0252..364e7a5 100644
--- a/drivers/scsi/cxlflash/ocxl_hw.c
+++ b/drivers/scsi/cxlflash/ocxl_hw.c
@@ -342,12 +342,18 @@ static void ocxlflash_unconfig_afu(struct ocxl_hw_afu 
*afu)
  static void ocxlflash_destroy_afu(void *afu_cookie)
  {
        struct ocxl_hw_afu *afu = afu_cookie;
+       int pos;

        if (!afu)
                return;

        ocxlflash_release_context(afu->ocxl_ctx);
        idr_destroy(&afu->idr);
+
+       /* Disable the AFU */
+       pos = afu->acfg.dvsec_afu_control_pos;
+       ocxl_config_set_afu_state(afu->pdev, pos, 0);
+
        ocxlflash_unconfig_afu(afu);
        kfree(afu);
  }
@@ -492,6 +498,9 @@ static int ocxlflash_config_afu(struct pci_dev *pdev, 
struct ocxl_hw_afu *afu)
                        __func__, rc);
                goto out;
        }
+
+       /* Enable the AFU */
+       ocxl_config_set_afu_state(pdev, acfg->dvsec_afu_control_pos, 1);
  out:
        return rc;
  }