On 02/08/2008 03:17 AM, Stephen Neuendorffer wrote: > This includes code for new fifo-based xps_hwicap in addition to the > older opb_hwicap, which has a significantly different interface. The > common code between the two drivers is largely shared. > > Significant differences exists between this driver and what is > supported in the EDK drivers. In particular, most of the > architecture-specific code for reconfiguring individual FPGA resources > has been removed. This functionality is likely better provided in a > user-space support library. In addition, read and write access is > supported. In addition, although the xps_hwicap cores support > interrupt-driver mode, this driver only supports polled operation, in > order to make the code simpler, and since the interrupt processing > overhead is likely to slow down the throughput under Linux. > > Signed-off-by: Stephen Neuendorffer <[EMAIL PROTECTED]> > > Fixed to add mutexes, and a few style issues. > > Acked-by: Grant Likely <[EMAIL PROTECTED]> > > The final update to xilinx_hwicap.h was missing. > > fix some missing __user tags and incorrect section tags. > convert semaphores to mutexes. > make probed_devices re-entrancy and error condition safe. > fix some backwards memcpys. > some other minor cleanups.
Looks good to me. > Signed-off-by: Stephen Neuendorffer <[EMAIL PROTECTED]> > --- [...] > diff --git a/drivers/char/xilinx_hwicap/xilinx_hwicap.c > b/drivers/char/xilinx_hwicap/xilinx_hwicap.c > new file mode 100644 > index 0000000..2caac31 > --- /dev/null > +++ b/drivers/char/xilinx_hwicap/xilinx_hwicap.c > @@ -0,0 +1,923 @@ [...] > +module_param(xhwicap_major, int, S_IRUGO); > +module_param(xhwicap_minor, int, S_IRUGO); > + > +/* An array, which is set to true when the device is registered. */ > +static bool probed_devices[HWICAP_DEVICES]; > +static struct mutex icap_sem; Just a sideway note, static DEFINE_MUTEX(icap_sem); and you don't need to runtime init it then. _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
