Hello Zhao Qiang, The patch bb8b2062aff3: "fsl/qe: setup clock source for TDM mode" from Jun 6, 2016, leads to the following static checker warning:
drivers/soc/fsl/qe/ucc.c:629 ucc_get_tdm_sync_shift() warn: both sides of ternary the same: '30' RX_SYNC_SHIFT_BASE RX_SYNC_SHIFT_BASE drivers/soc/fsl/qe/ucc.c 625 static u32 ucc_get_tdm_sync_shift(enum comm_dir mode, u32 tdm_num) 626 { 627 u32 shift; 628 629 shift = (mode == COMM_DIR_RX) ? RX_SYNC_SHIFT_BASE : RX_SYNC_SHIFT_BASE; ^^^^^^^^^^^^^^^^^^ Maybe this one should have been TX_? 630 shift -= tdm_num * 2; 631 632 return shift; 633 } regards, dan carpenter