On Mon, Jan 01, 2018 at 10:29:24PM +0100, Maciej S. Szmigiero wrote: > > @@ -445,16 +445,10 @@ static void fsl_ssi_config(struct fsl_ssi *ssi, bool > > enable, > > bool tx = &ssi->regvals[TX] == vals;
> > + /* Check if the opposite stream is active */ > > + aactive = ssi->streams & BIT(!tx); > > I don't think that hardcoding an implicit assumption here that RX == 0, > TX == 1 is a good thing. > If in the future, for any reason, somebody changes values of these macros > this code will silently break. > > I would instead change this line into something like > "aactive = ssi->streams & (tx ? BIT(RX) : BIT(TX));" or similar. You have a point. I could add a "bool dir" to make it clear. Thanks.
