On Thu, Oct 19, 2017 at 03:20:36PM +1100, Michael Ellerman wrote: > Ram Pai <linux...@us.ibm.com> writes: > > > diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig > > index 9fc3c0b..a4cd210 100644 > > --- a/arch/powerpc/Kconfig > > +++ b/arch/powerpc/Kconfig > > @@ -864,6 +864,22 @@ config SECCOMP > > > > If unsure, say Y. Only embedded should say N here. > > > > +config PPC64_MEMORY_PROTECTION_KEYS > > That's pretty wordy, can we make it CONFIG_PPC_MEM_KEYS ? > > I think you're a sufficient vim wizard to search and replace all > usages at once,
I take that as a compliment for now ;) > if not I can do it before I apply the series. Will change it...just that I was trying to keep it similar to what intel has X86_INTEL_MEMORY_PROTECTION_KEYS > > > + prompt "PowerPC Memory Protection Keys" > > + def_bool y > > + # Note: only available in 64-bit mode > > We don't need the note, that's exactly what the next line says: > > + depends on PPC64 > > But shouldn't it be BOOK3S_64 ? > > I don't think it works on BookE does it? > > > + select ARCH_USES_HIGH_VMA_FLAGS > > + select ARCH_HAS_PKEYS > > + ---help--- > > I prefer just "help". ok. > > > diff --git a/arch/powerpc/include/asm/mmu_context.h > > b/arch/powerpc/include/asm/mmu_context.h > > index 3095925..7badf29 100644 > > --- a/arch/powerpc/include/asm/mmu_context.h > > +++ b/arch/powerpc/include/asm/mmu_context.h > > @@ -141,5 +141,10 @@ static inline bool arch_vma_access_permitted(struct > > vm_area_struct *vma, > /* ....snip... > * Disable the pkey system till everything is in place. A patch > * further down the line will enable it. > */ > > I'm going to stop commenting on every badly formatted comment :) did not realize I had acquired a habit for badly formatted comments. :-( Sorry for causing the pain. Will fix it. RP
