On 10/19/2017 03:05 AM, Michael Ellerman wrote:
> [...]
> I know it's annoying when you get stuck with a box like this, but I
> can't merge this patch.
>
> You're *removing* the system administrators ability to control access to
> xmon (other than disabling sysrq entirely). That's a regression.
>
> What we should do is get a bit allocated for xmon, so it can have a
> non-zero single-bit enable mask.
>
Agree with you, thanks for the enlightening comment. Let's then drop
this one, since sysrq=1 would do the job for us now anyway.
Cheers,
Guilherme
> cheers
>
>
>> diff --git a/arch/powerpc/xmon/xmon.c b/arch/powerpc/xmon/xmon.c
>> index 4679aeb84767..780d708472a2 100644
>> --- a/arch/powerpc/xmon/xmon.c
>> +++ b/arch/powerpc/xmon/xmon.c
>> @@ -3514,6 +3514,7 @@ static struct sysrq_key_op sysrq_xmon_op = {
>> .handler = sysrq_handle_xmon,
>> .help_msg = "xmon(x)",
>> .action_msg = "Entering xmon",
>> + .enable_mask = 0xFFFF,
>> };
>>
>> static int __init setup_xmon_sysrq(void)
>> --
>> 2.14.2
>
