Re: [PATCH] powerpc/mm/radix: Drop unneeded NULL check

[Aneesh Kumar K.V]

On 10/17/2017 05:24 PM, Nicholas Piggin wrote:
On Mon, 16 Oct 2017 12:41:00 +0530
"Aneesh Kumar K.V" <aneesh.ku...@linux.vnet.ibm.com> wrote:

@@ -175,10 +175,9 @@ void radix__local_flush_tlb_page(struct vm_area_struct 
*vma, unsigned long vmadd
  #ifdef CONFIG_HUGETLB_PAGE
        /* need the return fix for nohash.c */
        if (vma && is_vm_hugetlb_page(vma))
-               return __local_flush_hugetlb_page(vma, vmaddr);
+               return radix__local_flush_hugetlb_page(vma, vmaddr);
  #endif
-       radix__local_flush_tlb_page_psize(vma ? vma->vm_mm : NULL, vmaddr,
-                                         mmu_virtual_psize);
+       radix__local_flush_tlb_page_psize(vma->vm_mm, vmaddr, 
mmu_virtual_psize);
  }
  EXPORT_SYMBOL(radix__local_flush_tlb_page);
  

Missed the other NULL pointer check in this hunk.

@@ -247,10 +246,9 @@ void radix__flush_tlb_page(struct vm_area_struct *vma, 
unsigned long vmaddr)
  {
  #ifdef CONFIG_HUGETLB_PAGE
        if (vma && is_vm_hugetlb_page(vma))
-               return flush_hugetlb_page(vma, vmaddr);
+               return radix__flush_hugetlb_page(vma, vmaddr);
  #endif
-       radix__flush_tlb_page_psize(vma ? vma->vm_mm : NULL, vmaddr,
-                                   mmu_virtual_psize);
+       radix__flush_tlb_page_psize(vma->vm_mm, vmaddr, mmu_virtual_psize);
  }
  EXPORT_SYMBOL(radix__flush_tlb_page);
  

And another one.


Didn't get that. We should not find vma NULL here. Hence i removed that 
vma == NULL check. Are you suggesting that this is not correct?

-aneesh