On Wed, Sep 20, 2017 at 02:47:08PM +1000, Michael Ellerman wrote: > Jose Ricardo Ziviani <jos...@linux.vnet.ibm.com> writes: > > > Today, each EEH causes a stack dump to be printed in the logs. In > > production environment it's not quite necessary. Thus, this patch > > I'm unconvinced. A production environment is exactly where you don't > want to be getting an EEH, and so if you *do* then every bit of > information is helpful. > > > For example, instead of the following: > > > > [ 131.778661] EEH: Frozen PHB#2-PE#fd detected > > [ 131.778672] EEH: PE location: N/A, PHB location: N/A > > [ 131.778677] CPU: 21 PID: 10098 Comm: lspci Not tainted ... > > [ 131.778680] Call Trace: > > [ 131.778686] [c0000003a140bab0] [c000000000beb58c] dump_stack+... > > <snip ~10 lines> > > [ 131.778770] EEH: Detected PCI bus error on PHB#2-PE#fd > > [ 131.778775] EEH: This PCI device has failed 1 times in the last hour > > ... > > > > we will have this by default: > > > > [12777.175880] EEH: Frozen PHB#2-PE#fd detected > > [12777.175893] EEH: PE location: N/A, PHB location: N/A > > [12777.175922] EEH: Detected PCI bus error on PHB#2-PE#fd > > [12777.175931] EEH: This PCI device has failed 2 times in the last hour > > *What* PCI device? > > How am I supposed to know what device/driver just failed? If I had the > stack trace I could probably at least work it out based on the driver > involved. > > cheers >
Thank you guys! More people told me it's important to keep it as is. Please, disregard this patch.
