Nathan Fontenot <nf...@linux.vnet.ibm.com> writes:
...
>
> Hopefully that helps clarify things.

Yep thanks. In short, read the code better Michael :)

I folded in this hunk, which will keep the compiler happy and is also
correct I believe. Basically in the success case (lmbs_added == lmbs_to_add)
we explicitly set rc to 0.

@@ -870,6 +873,7 @@ static int dlpar_memory_add_by_count(u32 lmbs_to_add, 
struct property *prop)
                                lmbs[i].base_addr, lmbs[i].drc_index);
                        lmbs[i].reserved = 0;
                }
+               rc = 0;
        }
 
        return rc;

cheers

Reply via email to