On Wed, Jul 26, 2017 at 08:03:30PM +1000, Michael Ellerman wrote: > Segher Boessenkool <seg...@kernel.crashing.org> writes: > > A general question about these patches: some things are inside #ifdef > > __powerpc64__, some are not. It seems it is the wrong macro, and it > > should be used (or not used) consistently? > > Why is it the wrong macro? Because we tend to use CONFIG_PPC64 you mean?
Yeah. But I see sstep.c already mixes those two at will (or if there is a distinction, I'm not seeing it :-) ) > I thought the reason some are #ifdef'ed is that some are 64-bit only. > ie. bpermd is 64-bit only ? 64-bit only, in what way? It's not clear what the rules are. It's not instructions that can only run in 64-bit mode. It's not instructions that only give a usable result with 64-bit regs implemented. It's not instructions only implemented on 64-bit CPUs. It's not even "all instructions that would not give a correct result in the low 32 bits of GPRs if the high 32 bits are not implemented". Segher
