On Mon 7/24/2017 3:04 PM, Dan Carpenter <[email protected]> > -----Original Message----- > From: Dan Carpenter [mailto:[email protected]] > Sent: Monday, July 24, 2017 3:04 PM > To: Qiang Zhao <[email protected]> > Cc: Leo Li <[email protected]>; [email protected]; kernel- > [email protected] > Subject: Re: [PATCH 1/2] fsl/qe: NULL dereference on error in > ucc_of_parse_tdm() > > On Mon, Jul 24, 2017 at 02:24:14AM +0000, Qiang Zhao wrote: > > On Sat 7/22/2017 3:34 PM, Dan Carpenter <[email protected]> > wrote: > > > > > -----Original Message----- > > > From: Dan Carpenter [mailto:[email protected]] > > > Sent: Saturday, July 22, 2017 3:34 PM > > > To: Qiang Zhao <[email protected]> > > > Cc: Leo Li <[email protected]>; [email protected]; > > > kernel- [email protected] > > > Subject: [PATCH 1/2] fsl/qe: NULL dereference on error in > > > ucc_of_parse_tdm() > > > > > > If "pdev = of_find_device_by_node(np2);" fails then it would lead to > > > a NULL dereference. This function is called from probe() and we're > > > using managed resources so we can just return without doing a manual > cleanup. > > > > You mean it will be cleaned up automatically? > > Yes. At module unload.
Do you mean when insmod it as a module, and when this module is removed, it will be cleaned up automatically? Do I understand correctly? Well, how about build-in? Best Regards Qiang Zhao
