On Tue, Jul 11, 2017 at 7:34 PM, Daniel Axtens <d...@axtens.net> wrote:
> Hi Matt,
>
>> Currently ppc_md.get_random_seed uses the powernv_get_random_long function.
>> A guest calling this function would have to go through the hypervisor. The
>> 'darn' instruction, introduced in POWER9, allows us to bypass this by
>> directly obtaining a value from the mmio region.
>>
>> This patch adds a function for ppc_md.get_random_seed on p9,
>> utilising the darn instruction.
>
> This patch looks pretty good - I'm not set up to test it but I have one
> code-style nit:
>
>> diff --git a/arch/powerpc/platforms/powernv/rng.c
>> b/arch/powerpc/platforms/powernv/rng.c
>> index 5dcbdea..ab6f411 100644
>> --- a/arch/powerpc/platforms/powernv/rng.c
>> +++ b/arch/powerpc/platforms/powernv/rng.c
>> @@ -8,6 +8,7 @@
>> */
>>
>> #define pr_fmt(fmt) "powernv-rng: " fmt
>> +#define DARN_ERR 0xFFFFFFFFFFFFFFFFul
>>
>> #include <linux/kernel.h>
>> #include <linux/of.h>
>> @@ -16,6 +17,7 @@
>> #include <linux/slab.h>
>> #include <linux/smp.h>
>> #include <asm/archrandom.h>
>> +#include <asm/cputable.h>
>> #include <asm/io.h>
>> #include <asm/prom.h>
>> #include <asm/machdep.h>
>> @@ -67,6 +69,21 @@ int powernv_get_random_real_mode(unsigned long *v)
>> return 1;
>> }
>>
>> +int powernv_get_random_darn(unsigned long *v)
>
> This is only referenced in this file so it should probably be labelled
> as 'static'.
>
That's true, my thinking was to then use the get_random_darn where the
get_random_long was being used.
Looks like there is only one other caller of it at the moment,
kvmppc_h_random (in arch/powerpc/kvm/book3s_hv_builtin.c).
We may want to change that to get_random_darn.
>> +{
>> + unsigned long val;
>> +
>> + /* Using DARN with L=1 - conditioned random number */
>> + asm (PPC_DARN(%0, 1)"\n" : "=r"(val) :);
>> +
>> + if (val == DARN_ERR)
>> + return 0;
>> +
>> + *v = val;
>> +
>> + return 1;
>
> I was a bit confused to see 1 representing success - I think I have been
> in userspace too long. But I checked against pseries_get_random_long and
> it is in fact correct, so good for you!
>
> An excellent followup patch would be changing the type of this function
> to be bool rather than int, but no pressure :)
That's probably a good idea!
Thanks,
Matt
>
> Regards,
> Daniel
>
>> +}
>> +
>> int powernv_get_random_long(unsigned long *v)
>> {
>> struct powernv_rng *rng;
>> @@ -136,6 +153,7 @@ static __init int rng_create(struct device_node *dn)
>> static __init int rng_init(void)
>> {
>> struct device_node *dn;
>> + unsigned long drn_test;
>> int rc;
>>
>> for_each_compatible_node(dn, NULL, "ibm,power-rng") {
>> @@ -150,6 +168,10 @@ static __init int rng_init(void)
>> of_platform_device_create(dn, NULL, NULL);
>> }
>>
>> + if (cpu_has_feature(CPU_FTR_ARCH_300) &&
>> + powernv_get_random_darn(&drn_test))
>> + ppc_md.get_random_seed = powernv_get_random_darn;
>> +
>> return 0;
>> }
>> machine_subsys_initcall(powernv, rng_init);
>> --
>> 2.9.3
