Michael Ellerman <m...@ellerman.id.au> writes: > Tyrel Datwyler <tyr...@linux.vnet.ibm.com> writes: >> On 06/01/2017 09:42 AM, christophe leroy wrote: >>> Le 01/06/2017 à 16:30, Aneesh Kumar K.V a écrit : >>>> diff --git a/arch/powerpc/include/asm/book3s/64/mmu-hash.h >>>> b/arch/powerpc/include/asm/book3s/64/mmu-hash.h >>>> index 6981a52b3887..67766e60a6b6 100644 >>>> --- a/arch/powerpc/include/asm/book3s/64/mmu-hash.h >>>> +++ b/arch/powerpc/include/asm/book3s/64/mmu-hash.h >>>> @@ -468,7 +468,7 @@ extern int htab_bolt_mapping(unsigned long vstart, >>>> unsigned long vend, >>>> int psize, int ssize); >>>> int htab_remove_mapping(unsigned long vstart, unsigned long vend, >>>> int psize, int ssize); >>>> -extern void add_gpage(u64 addr, u64 page_size, unsigned long >>>> number_of_pages); >>>> +extern void pSeries_add_gpage(u64 addr, u64 page_size, unsigned long >>>> number_of_pages); >>> >>> Linux kernel coding style says 'mixed-case names are frowned upon' >> >> True, but there is precedent within arch/powerpc/platforms/pseries seeing as >> "pSeries_" is >> already used heavily to prefix function names. > > True, but it's still horrible. Any new names should just use "pseries".
I will update in the next iteration. I will wait to get feedback on FSL/8xx before posting the next version. -aneesh
