On Sun, 2008-01-20 at 10:18 -0500, Jon Smirl wrote: > > So it seems to me like the polling mode code is never actually used? > > Unless some platforms include an "empty" IRQ in their device > > definition. Which indeed seems to be the case... but then they set > the > > IRQ to 0, NOT to NO_IRQ, so I'm wondering if the change you propose > is > > really correct. > > All of this is very confusing to me, There are physical IRQs and > virtual IRQs. Apparently zero is a legal physical IRQ but it is not a > legal virtual IRQ. We only get virtual IRQs in this code. We need to > get BenH to give us the right answer on these two cases.
Testing against NO_IRQ for a linux IRQ number should always be correct. Physical IRQ numbers are remapped and shouldn't be visible to drivers, NO_IRQ is a value that never exist for a valid logical interrupt number, that is 0 for arch/powerpc and -1 for arch/ppc. Ben. _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
