"Tobin C. Harding" <m...@tobin.cc> writes: > struct hcall_stats is only used in hvCall_inst.c. > > Move struct hcall_stats to hvCall_inst.c > > Resolves: #54 > Signed-off-by: Tobin C. Harding <m...@tobin.cc> > --- > > Is this correct, adding 'Resolves: #XX' when fixing > github.com/linuxppc/linux issues?
Not in the change log (the part above ---). That gets committed to the history, and we don't want to clutter that with github issue numbers. The kernel history will probably outlive the github issues, at which point the issue numbers become meaningless. You can put Resolves: in this section (below ---), if you like. That is just informational and doesn't get committed. But I'm also happy to just close the github issues manually. When I do that I make a link from the issue to the commit, but not the other way around. cheers
