Hi Michael, On Mon, 6 Mar 2017 23:05:17 +1100 Michael Ellerman <m...@ellerman.id.au> wrote: > > We have a big list of selects under CONFIG_PPC, and currently they're > completely unsorted. This means people tend to add new selects at the > bottom of the list, and so two commits which both add a new select will > often conflict. > > Instead sort it alphabetically. This is nicer in and of itself, but also > means two commits that add a new select will have a greater chance of > not conflicting. > > Add a note at the top and bottom asking people to keep it sorted. > > And while we're here pad out the 'if' expressions to make them stand > out. > > Suggested-by: Stephen Rothwell <s...@canb.auug.org.au> > Signed-off-by: Michael Ellerman <m...@ellerman.id.au>
Looks good. > + select ARCH_USE_CMPXCHG_LOCKREF if PPC64 Why not just move these "if PPC64" selects to "config PPC64" in arch/powerpc/platforms/Kconfig.cputype? Secondary question: why not move "config PPC64" to this file? > + select GENERIC_ATOMIC64 if PPC32 Similarly ... -- Cheers, Stephen Rothwell
