On Wed, Jan 16, 2008 at 03:12:10PM -0700, Mark A. Greer wrote:
> From: Mark A. Greer <[EMAIL PROTECTED]>
>
> Add support for the Emerson Katana 750i & 752i platforms.
>
> Signed-off-by: Mark A. Greer <[EMAIL PROTECTED]>
[snip]
> +typedef enum {
> + BOARD_TYPE_750I,
> + BOARD_TYPE_752I,
> +} katana750i_board_type;
This enum appears to be pointless. You never use it as a type, and
there's no reason to explicitly give array indices for the
board_info[] array.
> +struct katana750i_board_info {
> + char cpld_prod_id;
> + char *model;
> + char *bridge_type;
> +};
> +
> +static struct katana750i_board_info katana750i_board_info[] = {
> + [BOARD_TYPE_750I] = {
> + .cpld_prod_id = KATANA750I_PRODUCT_ID_750I,
> + .model = "Katana-750i",
> + .bridge_type = "mv64360",
> + },
> + [BOARD_TYPE_752I] = {
> + .cpld_prod_id = KATANA750I_PRODUCT_ID_752I,
> + .model = "Katana-752i",
> + .bridge_type = "mv64460",
> + },
> +};
[...]
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
