Oliver O'Halloran <ooh...@gmail.com> writes:
> On Mon, Feb 27, 2017 at 9:56 PM, Michael Ellerman <m...@ellerman.id.au> wrote:
>> Matt Brown <matthew.brown....@gmail.com> writes:
>>> diff --git a/arch/powerpc/platforms/powernv/opal-hdat.c
>>> b/arch/powerpc/platforms/powernv/opal-hdat.c
>>> new file mode 100644
>>> index 0000000..3315dd3
>>> --- /dev/null
>>> +++ b/arch/powerpc/platforms/powernv/opal-hdat.c
>>> @@ -0,0 +1,65 @@
>> ...
>>> +
>>> +
>>> +/* HDAT attribute for sysfs */
>>> +static struct bin_attribute hdat_attr = {
>>> + .attr = {.name = "hdat", .mode = 0444},
>> ^^^^
>> ajd and oohal report to my office.
>
> I don't think there's anything in the HDAT that's sensitive. That
> said, this might not be true in the future so making it only readable
> by root might be a good idea.
Right. What's sensitive can also change over time, in addition to the
actual content changing without our knowledge.
This is also firmly a debugging thing, so unless there's a compelling
reason why it should be world readable then it shouldn't be.
So 0400 please.
cheers
