Re: [PATCH 1/2] powerpc/powernv/opal-dump : Handles opal_dump_info properly

[Mukesh Ojha]

Hi Micheal,

Can you please look at this patchset?

-Mukesh


On Tuesday 06 December 2016 12:07 PM, Mukesh Ojha wrote:

Hi Michael,

Can you please have a look at this patchset as there is no

functional changes involve with this?

Thanks,
Mukesh




On Thursday 01 December 2016 02:38 PM, Mukesh Ojha wrote:

Moves the return value check of 'opal_dump_info' to a proper place which
was previously unnecessarily filling all the dump info even on failure.

Signed-off-by: Mukesh Ojha <mukes...@linux.vnet.ibm.com>
---
  arch/powerpc/platforms/powernv/opal-dump.c | 9 ++++++---
  1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/arch/powerpc/platforms/powernv/opal-dump.c b/arch/powerpc/platforms/powernv/opal-dump.c

index 4c82782..ae32212 100644
--- a/arch/powerpc/platforms/powernv/opal-dump.c
+++ b/arch/powerpc/platforms/powernv/opal-dump.c

@@ -225,13 +225,16 @@ static int64_t dump_read_info(uint32_t *dump_id, uint32_t *dump_size, uint32_t *

      if (rc == OPAL_PARAMETER)
          rc = opal_dump_info(&id, &size);

+    if (rc) {
+        pr_warn("%s: Failed to get dump info (%d)\n",
+            __func__, rc);
+        return rc;
+    }
+
      *dump_id = be32_to_cpu(id);
      *dump_size = be32_to_cpu(size);
      *dump_type = be32_to_cpu(type);

-    if (rc)
-        pr_warn("%s: Failed to get dump info (%d)\n",
-            __func__, rc);
      return rc;
  }