On Wed, Jan 18, 2017 at 2:37 PM, Ard Biesheuvel <ard.biesheu...@linaro.org> wrote: > > For a ballpark number of 10,000 CRCs in the core kernel, this would > increase the size of the image by 40 KB for 32-bit architectures (and > if saving 40 KB is essential, chances are you won't be using > modversions in the first place).
As you say, I don't think the space issue is much of a problem. I'm more worried about the replacement of one crazy model that has problems due to linker subtlety with _another_ one. Your genksyms.c change is not exactly obvious. I looked at it, and my brain just shut down. Why both the LONG(0x%08lx); _and_ the "%s__crc_%s = 0x%08lx;\n" in the linker script? I'm sure there's a good reason, but I'd like to see a more explicit explanation fo what the generated linker script does and what the rules are. Linus