It has been pointed out that this actually occured in 2017. My apologies. On 17/01/2017 9:50 PM, "Oliver O'Halloran" <ooh...@gmail.com> wrote:
> "It's possible I missed one, but I did genuinely review all of it" > > Cyril Bur, 2016 > In a hobart pub, specifically The Winston > > On 17/01/2017 8:53 PM, "Michael Ellerman" <m...@ellerman.id.au> wrote: > >> Cyril Bur <cyril...@gmail.com> writes: >> >> > On Thu, 2017-01-12 at 14:54 +1100, Russell Currey wrote: >> >> Symbolic macros are unintuitive and hard to read, whereas octal >> constants >> >> are much easier to interpret. Replace macros for the basic permission >> >> flags (user/group/other read/write/execute) with numeric constants >> >> instead, across the whole powerpc tree. >> >> >> >> Introducing a significant number of changes across the tree for no >> runtime >> >> benefit isn't exactly desirable, but so long as these macros are still >> >> used in the tree people will keep sending patches that add them. Not >> only >> >> are they hard to parse at a glance, there are multiple ways of coming >> to >> >> the same value (as you can see with 0444 and 0644 in this patch) which >> >> hurts readability. >> >> >> >> Signed-off-by: Russell Currey <rus...@russell.cc> >> > >> > Reviewed-by: Cyril Bur <cyril...@gmail.com> >> >> Did you really really review every single change? >> >> Because if you did then I don't have to, and that would be *great* :) >> >> cheers >> >
