On Tuesday 20 December 2016 02:33 PM, Balbir Singh wrote:

On 19/12/16 19:06, Madhavan Srinivasan wrote:
Move set_soft_enabled() from powerpc/kernel/irq.c to
asm/hw_irq.c, to force updates to paca-soft_enabled
done via these access function. Add "memory" clobber
to hint compiler since paca->soft_enabled memory is the target
here
+static inline notrace void soft_enabled_set(unsigned long enable)
+{
+       __asm__ __volatile__("stb %0,%1(13)"
+       : : "r" (enable), "i" (offsetof(struct paca_struct, soft_enabled))
+       : "memory");
+}
+
Can't we just rewrite this in "C"?

local_paca->soft_enabled = enable

Yes we did discussed this and parked it to handle in the follow on patchset.
Nick did suggest something of this sort,

__asm__ __volatile__("stb %1,%0" : "=m" (local_paca->soft_enabled) : "r" (enable));



Balbir Singh.


Reply via email to