On Sun, Jan 06, 2008 at 04:46:24PM -0600, Scott Wood wrote: > On Sun, Jan 06, 2008 at 02:37:16PM +1100, David Gibson wrote: > > > out: > > > + free((void *)file->dir); > > > > That cast shouldn't be there. > > It generates a constness warning otherwise. I was on the fence over > whether to just remove the constness (even though the data is never > modified during its lifetime); would that be preferable?
I think that is preferable. -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev