> >@@ -550,15 +550,10 @@ static int uniphier_fi2c_probe(struct platform_device
> >*pdev)
> > }
> >
> > ret = i2c_add_adapter(&priv->adap);
> >- if (ret) {
> >- dev_err(dev, "failed to add I2C adapter\n");
> >- goto err;
> >- }
> >-
> >-err:
> > if (ret)
> > clk_disable_unprepare(priv->clk);
> >
> >+ err:
>
> You sure about that one ? It leaves the clock enabled in some of the error
> paths.Uh, ehrm, where is the brown paper bag? Thanks, Guenter! > Note: I dropped all individuals from Cc:; my mailer refused to accept the > reply because there > were too many. Yes, the disadvantage of not breaking out.
signature.asc
Description: PGP signature
