Jochen Friedrich wrote:
>>> + [EMAIL PROTECTED] {
>>> + label = "Flash without bootloader";
>>> + reg = <20000 7e0000>;
>>> + };
>>> + [EMAIL PROTECTED] {
>>> + label = "Complete Flash";
>>> + reg = <0 800000>;
>>> + read-only;
>>> + };
>>
>> What is "ovpartition"?
>
> Overlay partition. Is there a better way to specify this?
Not sure... what will the mtd code do with this?
>>> + [EMAIL PROTECTED] {
>>> + reg = <970 10>;
>>> + compatible = "samsung,ks0713";
>>> + };
>>
>> So some driver that matches on samsung,ks0713 has to know the details
>> of the
>> mpc8xx GPIO registers?
>
> The GPIO API only has an accessor for 1bit I/O. The LCD, however has for
> 1bit
> control lines and an 8bit port. The GPIO API currently is unable to
> handle this.
Right, but we shouldn't weird up the device tree because of Linux's
weaknesses. Ideally, the GPIO API should support wider I/O; in the
meantime, there should be something in the board file that tells the
ks0713 driver what to do.
>> I'd use separate device trees (I only did this kind of thing in mpc885ads
>> because it's dip-switchable), but whatever...
>
> I don't really like having to use different images on different DBoxes.
> It's
> already too much to have two images (there are two different flash
> layouts).
> People tend to brick their box by flashing the wrong image.
Fair enough.
> [EMAIL PROTECTED] {
> [EMAIL PROTECTED],0 {
> compatible = "betaresearch,dbox2-cam";
> reg = <3 0 20000 6 0 20000>;
> interrupts = <6 2>;
> interrupt-parent = <&PIC>;
> gpios = <1 1c 1 1d 1 1e 1 1f>;
> gpio-parent = <&CPM1_PIO>;
> };
> };
> [EMAIL PROTECTED] {
> [EMAIL PROTECTED] {
> CPM1_PIO: [EMAIL PROTECTED] {
> [EMAIL PROTECTED],0 {
> compatible = "betaresearch,dbox2-fp";
> interrupts = <4 2>;
> interrupt-parent = <&PIC>;
> gpios = <0 e>;
> gpio-parent = <&CPM1_PIO>;
> };
> };
> [EMAIL PROTECTED] {
> [EMAIL PROTECTED] {
> compatible = "betaresearch,dbox2-fp";
> reg = <30>;
> };
> [EMAIL PROTECTED] {
> compatible = "betaresearch,dbox2-cam";
> reg = <37>;
> };
> };
> };
> };
I'd make the compatible name specific to the interface (e.g.
"betaresearch,dbox2-cam-mmio", "betaresearch,dbox2-fp-i2c"), use reg
rather than gpios/gpio-parent, and use phandle linkage between the
different inteferfaces of a device. But yes, multiple nodes is the
sanest way to do it.
-Scott
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
