On 2016/06/21 09:38AM, Michael Ellerman wrote:
> On Sun, 2016-06-19 at 23:06 +0530, Naveen N. Rao wrote:
> > On 2016/06/17 10:53PM, Michael Ellerman wrote:
> > > On Tue, 2016-07-06 at 13:32:23 UTC, "Naveen N. Rao" wrote:
> > > > diff --git a/arch/powerpc/net/bpf_jit_comp64.c
> > > > b/arch/powerpc/net/bpf_jit_comp64.c
> > > > new file mode 100644
> > > > index 0000000..954ff53
> > > > --- /dev/null
> > > > +++ b/arch/powerpc/net/bpf_jit_comp64.c
> > > > @@ -0,0 +1,956 @@
> > > ...
>
> > > > +
> > > > +static void bpf_jit_fill_ill_insns(void *area, unsigned int size)
> > > > +{
> > > > + int *p = area;
> > > > +
> > > > + /* Fill whole space with trap instructions */
> > > > + while (p < (int *)((char *)area + size))
> > > > + *p++ = BREAKPOINT_INSTRUCTION;
> > > > +}
> > >
> > > This breaks the build for some configs, presumably you're missing a
> > > header:
> > >
> > > arch/powerpc/net/bpf_jit_comp64.c:30:10: error:
> > > 'BREAKPOINT_INSTRUCTION' undeclared (first use in this function)
> > >
> > > http://kisskb.ellerman.id.au/kisskb/buildresult/12720611/
> >
> > Oops. Yes, I should have caught that. I need to add:
> >
> > #include <asm/kprobes.h>
> >
> > in bpf_jit_comp64.c
> >
> > Can you please check if it resolves the build error?
>
> Can you? :D
:)
Sorry, I should have explained myself better. I did actually try your
config and I was able to reproduce the build error. After the above
#include, that error went away, but I saw some vdso related errors. I
thought I was doing something wrong and needed a different setup for
that particular kernel config, which is why I requested your help in the
matter. I just didn't do a good job of putting across that message...
Note to self: randconfig builds *and* more time drafting emails :)
Do you want me to respin the patches?
Thanks,
Naveen
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
